linux-kernel - Re: [PATCHv3 08/14] HSI: Introduce OMAP SSI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140425183604.GD22721@earth.universe>
Date:	Fri, 25 Apr 2014 20:36:05 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Pavel Machek <pavel@....cz>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Shubhrajyoti Datta <omaplinuxkernel@...il.com>,
	Carlos Chinea <cch.devel@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Pali Rohár <pali.rohar@...il.com>,
	Ивайло Димитров 
	<freemangordon@....bg>,
	Joni Lapilainen <joni.lapilainen@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Carlos Chinea <carlos.chinea@...ia.com>
Subject: Re: [PATCHv3 08/14] HSI: Introduce OMAP SSI driver

On Sat, Apr 19, 2014 at 09:30:51PM +0200, Pavel Machek wrote:
> > Add OMAP SSI driver to the HSI subsystem.
> > 
> > The Synchronous Serial Interface (SSI) is a legacy version
> > of HSI. As in the case of HSI, it is mainly used to connect
> > Application engines (APE) with cellular modem engines (CMT)
> > in cellular handsets.
> > 
> > It provides a multichannel, full-duplex, multi-core communication
> > with no reference clock. The OMAP SSI block is capable of reaching
> > speeds of 110 Mbit/s.
> > 
> > Signed-off-by: Carlos Chinea <carlos.chinea@...ia.com>
> > Signed-off-by: Sebastian Reichel <sre@...nel.org>
> 
> > +	bool			wktest:1; /* FIXME: HACK to be removed */
> > +	bool			wkin_cken:1; /* Workaround */
> 
> There is more thanone FIXME in the code. It may be better to fix after
> merge...

I would prefer to keep them in there and have a look after the
merge. Most FIXMEs in the code are for the wakeline test and some
concern the timings. Since the current code works I would prefer
to add it to the mainline kernel and tackle this afterwards.

> > +DEFINE_SIMPLE_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");
> > +
> > +static int __init ssi_debug_add_port(struct omap_ssi_port *omap_port,
> > +							struct dentry *dir)
> > +{
> 
> A little strange indentation. Is it intentional?
>
> [...] (more ugly indentation cases)

Fixed in v4.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)