linux-kernel - Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398458399.164274248@f343.i.mail.ru>
Date:	Sat, 26 Apr 2014 00:39:59 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Jon Ringle <jringle@...dpoint.com>,
	jon@...gle.org
Subject: Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

Fri, 25 Apr 2014 13:35:28 -0700 от Greg KH <gregkh@...uxfoundation.org>:
> On Sat, Apr 26, 2014 at 12:26:16AM +0400, Alexander Shiyan wrote:
> > Fri, 25 Apr 2014 13:23:15 -0700 от Greg KH <gregkh@...uxfoundation.org>:
> > > On Fri, Apr 25, 2014 at 03:53:09PM -0400, jon@...gle.org wrote:
> > > > From: Jon Ringle <jringle@...dpoint.com>
> > > > 
> > > > Signed-off-by: Jon Ringle <jringle@...dpoint.com>
> > > > ---
> > > >  drivers/tty/serial/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > > index c3e2b32..64c5659 100644
> > > > --- a/drivers/tty/serial/Kconfig
> > > > +++ b/drivers/tty/serial/Kconfig
> > > > @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
> > > >  
> > > >  config SERIAL_SC16IS7XX
> > > >  	tristate "SC16IS7xx serial support"
> > > > +	depends on I2C
> > > >  	select SERIAL_CORE
> > > >  	select REGMAP_I2C if I2C
> > > >  	help
> > > > -- 
> > > > 1.8.5.4
> > > 
> > > Better, but I still have the build warnings :(
> > 
> > I hope not same as before?
> 
> Exactly the same.

Hmm...

In the source:
#ifdef CONFIG_REGMAP_I2C
Should be of course #ifdef CONFIG_I2C
But this should not provide such warnings...

---