linux-kernel - Re: mmotm 2014-04-24-13-07 uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <535ACB0E.4070600@infradead.org>
Date:	Fri, 25 Apr 2014 13:52:30 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Rik van Riel <riel@...hat.com>
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Richard Weinberger <richard@....at>,
	linux-next@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	umgwanakikbuti@...il.com
Subject: Re: mmotm 2014-04-24-13-07 uploaded

On 04/25/14 13:44, Randy Dunlap wrote:
> On 04/25/14 07:04, Rik van Riel wrote:
>> On Thu, 24 Apr 2014 15:40:29 -0700
>> Randy Dunlap <rdunlap@...radead.org> wrote:
>>
>>
>>> uml on x86_64 defconfig:
>>>
>>> drivers/built-in.o: In function `__handle_sysrq':
>>> drivers/tty/sysrq.c:514: undefined reference to `rcu_sysrq_start'
>>> drivers/tty/sysrq.c:558: undefined reference to `rcu_sysrq_end'
>>
>> Randy, does the patch below fix it?

CONFIG_TINY_RCU=y

tiny.c does not provide these functions...  Paul...

> Hm, no, it does not.  I'll look into it.
> 
>> Mike, this patch should also address your concerns.
>>
>> Andrew, this can be a -fix patch for the sysctl-rcu patch,
>> assuming it fixes things :)
>>
>> Signed-off-by: Rik van Riel <riel@...hat.com
>> ---
>>  drivers/tty/sysrq.c | 1 +
>>  kernel/rcu/update.c | 3 ++-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
>> index dd53af9..0867433 100644
>> --- a/drivers/tty/sysrq.c
>> +++ b/drivers/tty/sysrq.c
>> @@ -46,6 +46,7 @@
>>  #include <linux/jiffies.h>
>>  #include <linux/syscalls.h>
>>  #include <linux/of.h>
>> +#include <linux/rcupdate.h>
>>  
>>  #include <asm/ptrace.h>
>>  #include <asm/irq_regs.h>
>> diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
>> index 2ac3289..d22309c 100644
>> --- a/kernel/rcu/update.c
>> +++ b/kernel/rcu/update.c
>> @@ -322,7 +322,8 @@ int rcu_jiffies_till_stall_check(void)
>>  
>>  void rcu_sysrq_start(void)
>>  {
>> -	rcu_cpu_stall_suppress = 2;
>> +	if (!rcu_cpu_stall_suppress)
>> +		rcu_cpu_stall_suppress = 2;
>>  }
>>  
>>  void rcu_sysrq_end(void)
>>
> 
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/