linux-kernel - Re: [PATCH 1/1] staging: android: Fix warning cast removes address space of expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140425221625.GA2936@kroah.com>
Date:	Fri, 25 Apr 2014 15:16:25 -0700
From:	Greg KH <greg@...ah.com>
To:	Camille Bordignon <camille.bordignon@...il.com>
Cc:	arve@...roid.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: android: Fix warning cast removes address
 space of expression

On Sun, Apr 20, 2014 at 11:10:57AM +0200, Camille Bordignon wrote:
> Fix sparse warning "cast removes address space of expression"
> Add lost flag "__user" due to cast
> 
> Signed-off-by: Camille Bordignon <camille.bordignon@...il.com>
> ---
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index cfe4bc8..952c4ae 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -2683,16 +2683,21 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  		binder_free_thread(proc, thread);
>  		thread = NULL;
>  		break;
> -	case BINDER_VERSION:
> -		if (size != sizeof(struct binder_version)) {
> +	case BINDER_VERSION: {
> +		struct binder_version __user *bv = ubuf;
> +
> +		if (size != sizeof(*bv)) {
>  			ret = -EINVAL;
>  			goto err;
>  		}
> -		if (put_user(BINDER_CURRENT_PROTOCOL_VERSION, &((struct binder_version *)ubuf)->protocol_version)) {
> +
> +		if (put_user(BINDER_CURRENT_PROTOCOL_VERSION,
> +				&bv->protocol_version)) {
>  			ret = -EINVAL;
>  			goto err;
>  		}
>  		break;
> +	}
>  	default:
>  		ret = -EINVAL;
>  		goto err;
> 
> 

This does not apply to my tree :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/