linux-kernel - Re: [PATCH 2/2] Staging:keucr:scsiglue.c-no semicolon terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2014 15:23:56 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Paul McQuade <paulmcquad@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging:keucr:scsiglue.c-no semicolon terminated

On Tue, Apr 08, 2014 at 05:32:45PM +0100, Paul McQuade wrote:
> WARNING: do {} while (0) macros should not be semicolon terminated
> 
> Signed-off-by: Paul McQuade <paulmcquad@...il.com>
> ---
>  drivers/staging/keucr/scsiglue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
> index ac3d34d..fce19a4 100644
> --- a/drivers/staging/keucr/scsiglue.c
> +++ b/drivers/staging/keucr/scsiglue.c
> @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
>  	do { \
>  		if (us->fflags & value) \
>  			SPRINTF(" " #name); \
> -	} while (0);
> +	} while (0)
>  US_DO_ALL_FLAGS
>  #undef US_FLAG
>  	seq_putc(m, '\n');

Why would you send a patch that you obviously have not at least compile
tested?

Hint, this breaks the build :(

ALWAYS test build your patches, to not do so is rude to others, don't
you agree?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/