| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <535AE52B.4010104@gmail.com> Date: Sat, 26 Apr 2014 00:43:55 +0200 From: Tomasz Figa <tomasz.figa@...il.com> To: Pankaj Dubey <pankaj.dubey@...sung.com>, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org CC: kgene.kim@...sung.com, linux@....linux.org.uk, t.figa@...sung.com, chow.kim@...sung.com, yg1004.jang@...sung.com, vikas.sajjan@...sung.com, s.nawrocki@...sung.com, b.zolnierkie@...sung.com Subject: Re: [PATCH v2 00/10] ARM: Exynos: PMU cleanup and refactoring for using DT Hi Pankaj, Just a small note - please refrain from sending next versions of series in reply to previous version. With threading applied, it gets hard to notice that a new version was posted, because the first message of the thread is always v1. Also it makes threads unnecessarily long. Best regards, Tomasz On 25.04.2014 14:32, Pankaj Dubey wrote: > This patch series, does some minor cleanup and modifies Exynos PMU related > code for mapping and initialization of Exynos Power Management Unit (PMU) > base address from device tree. This is also preparation for moving PMU > related code out of machine folder and moving into a "drivers/mfd", so that > ARM64 based SoC can utilize common piece of code. These patches require change > in Exynos4210, Exynos4212 and Exynos4412 dtsi files, which has been posted > as separate patch series [2] > > These patches are created on top of Kukjin Kim's for-next (v3.15-rc1 tag) > branch. > > These patches depends on following two patch series: > 1) mfd: syscon: Support early initialization > https://lkml.org/lkml/2014/4/8/239 > 2) Add PMU node for Exynos SoCs > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg29329.html > > We have tested these patches on SMDK5250 and Arndale (Exynos5250) boards for > System boot and PMU initialization and S2R. > > For testing on Arndale (Exynos5250) board: > Tested-by: Pankaj Dubey <pankaj.dubey@...sung.com> > > Changes Since v1: > - Rebased on latest for-next of Kukjin Kim's tree. > - Added patch: "Make exynos machine_ops as static". > For making more cleanup in "mach-exynos/common.h" > as suggested by Tomasz Figa. > - Addressed comments of Tomasz Figa for cleaning "mach-exynos/common.h". > - Updated patch: Remove file path from comment section > As suggested by Michel Simek, instead of updating file path > lets remove them from each file under "mach-exynos". > Even though Kukjin pointed out that there is similar patch pending from > Sachin/Tushar but since I could not find I have included this here. If > I have missed something please point to any existing such patch. > - Updated patch: Add support for mapping PMU base address via DT > - Removed __initdata from declaration of "exynos_pmu_base", as it caused > kernel crash as pointed out by Vikas Sajjan. > - Added support for Syscon initialization and getting PMU regmap handle > as suggested by Sylwester. Since current implementation of early > intialization [1] has limitation that "early_syscon_init" requires > DT to be unflattened and system should be able to allocate memory, > we can't use regmap handles for platsmp.c file as "smp_secondary_init" > will be called before DT unflattening. So I have kept both method for > accessing PMU base address. platsmp.c will use ioremmaped address where > as rest other files can use regmap handle. > - Added patch: Remove "linux/bug.h" from pmu.c. > - Updated patch: Refactored code for PMU register mapping via DT > - Modified to use regmap_read/write when using regmap handle. > - Added patch: Move "mach/map.h" inclusion from regs-pmu.h to platsmp.c > - Added patch: Add device tree based initialization support for PMU. > - Convert existing PMU implementation to be a device tree based > before moving it to "drivers/mfd" folder. As suggested by Bartlomiej. > - Dropped making a platform_driver for PMU, as currently PMU binding > has two compatibility strings as "samsung, exynosxxx-pmu", "syscon", > once we enable MFD_SYSCON config option, current "syscon" driver probe > gets called and PMU probe never gets called. So modified PMU > initialization code to scan DT and match against supported compatiblity > string in driver code, and once we get matching node use that for > accessing PMU regmap handle using "syscon_early_regmap_lookup_by_phandle". > If there is any better solution please suggest. > > Pankaj Dubey (6): > ARM: EXYNOS: Make exynos machine_ops as static > ARM: EXYNOS: Cleanup "mach-exynos/common.h" file > ARM: EXYNOS: Remove file path from comment section > ARM: EXYNOS: Refactored code for using PMU address via DT > ARM: EXYNOS: Move "mach/map.h" inclusion from regs-pmu.h to platsmp.c > ARM: EXYNOS: Add device tree based initialization support for PMU. > > Young-Gun Jang (4): > ARM: EXYNOS: Move SYSREG definition into sys-reg specific file. > ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain > ARM: EXYNOS: Add support for mapping PMU base address via DT > ARM: EXYNOS: Remove "linux/bug.h" from pmu.c > > arch/arm/mach-exynos/Kconfig | 2 + > arch/arm/mach-exynos/common.h | 13 +- > arch/arm/mach-exynos/cpuidle.c | 37 +- > arch/arm/mach-exynos/exynos.c | 104 +++++- > arch/arm/mach-exynos/headsmp.S | 2 - > arch/arm/mach-exynos/hotplug.c | 7 +- > arch/arm/mach-exynos/include/mach/map.h | 3 - > arch/arm/mach-exynos/include/mach/memory.h | 3 +- > arch/arm/mach-exynos/platsmp.c | 17 +- > arch/arm/mach-exynos/pm.c | 61 ++-- > arch/arm/mach-exynos/pm_domains.c | 2 +- > arch/arm/mach-exynos/pmu.c | 191 ++++++++--- > arch/arm/mach-exynos/regs-pmu.h | 512 ++++++++++++++-------------- > arch/arm/mach-exynos/regs-sys.h | 22 ++ > 14 files changed, 585 insertions(+), 391 deletions(-) > create mode 100644 arch/arm/mach-exynos/regs-sys.h > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists