linux-kernel - Re: [PATCH next-20140424] staging/cxt1e1: hwprobe.c sparse warning corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140426154247.GA18512@kroah.com>
Date:	Sat, 26 Apr 2014 08:42:47 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sami Laine <laine.j.sami@...il.com>
Cc:	daeseok.youn@...il.com, devel@...verdev.osuosl.org,
	trivial@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next-20140424] staging/cxt1e1: hwprobe.c sparse warning
 corrections

On Sat, Apr 26, 2014 at 06:30:33PM +0300, Sami Laine wrote:
> From: Sami Laine <laine.j.sami@...il.com>
> 
> Sparse warning corrections:
>  - declarations made static where they should be such
>  - changed NULL-pointers as NULL instead of static 0's
>  - added __force to a few casts seemingly safe enough

You did 3 different things here, can you split this up into 3 different
patches?  Especially as someone already sent in the NULL pointer
patch...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/