linux-kernel - Re: [PATCH 1/2] regulator: arizona-micsupp: Fix build errors with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140426165931.GV12304@sirena.org.uk>
Date:	Sat, 26 Apr 2014 17:59:31 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regulator: arizona-micsupp: Fix build errors with
 CONFIG_OF not defined

On Fri, Apr 25, 2014 at 09:30:53PM +0100, Charles Keepax wrote:
> On Fri, Apr 25, 2014 at 05:11:38PM +0100, Mark Brown wrote:
> > On Fri, Apr 25, 2014 at 04:55:40PM +0100, Charles Keepax wrote:

> > > Some of the OF handling functions do not have empty alternatives defined
> > > if CONFIG_OF is not defined. This patch ifdefs out the offending code.

> > Which functions and why is it not better to provide the stubs?

> Specifically of_get_child_by_name, of_parse_handle and
> of_node_put, I guess stub would probably be better. I will do
> a patch for that instead.

There's already a stub for of_get_child_by_name() in current code.
of_parse_handle() might not be ideal, I'd need to check the usage, but
I'd definitely expect to see a stub for of_node_put(), it's quite common
to need it even for fairly basic parsing.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)