linux-kernel - Re: [rfc PATCH] checkpatch: allow multiple const * types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140426194208.GG4963@mwanda>
Date:	Sat, 26 Apr 2014 22:52:26 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...dowen.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nicolas Del Piano <ndel314@...il.com>,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, mail@...ndporr.me.uk
Subject: Re: [rfc PATCH] checkpatch: allow multiple const * types

On Fri, Apr 25, 2014 at 08:29:59PM -0700, Joe Perches wrote:
> On Fri, 2014-04-25 at 10:50 +0300, Dan Carpenter wrote:
> > On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
> > > diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> []
> > > @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
> > >  static void comedi_report_boards(struct comedi_driver *driv)
> > >  {
> > >  	unsigned int i;
> > > +
> > >  	const char *const *name_ptr;
> > 
> > The original code was correct.  This is a bug in checkpatch.pl.  The
> > missing line check should count any lines starting with "const" or
> > "static" as declarations.
> 
> Right, thanks for the report.
> 
> I'm not around for a couple weeks.
> I'll fix it properly later.

No stress.  These are not a big deal.  These false positives are rare,
there is no way we would have applied the patch and even if we did then
the extra blank line is harmless.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/