linux-kernel - Re: [PATCH] usb_wwan: some improvement on write and resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140427102719.GJ2206@localhost>
Date:	Sun, 27 Apr 2014 12:27:19 +0200
From:	Johan Hovold <jhovold@...il.com>
To:	Xiao Jin <jin.xiao@...el.com>
Cc:	Johan Hovold <jhovold@...il.com>, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	juan.zou@...el.com, yanmin.zhang@...el.com,
	david.a.cohen@...ux.intel.com, "Zhang, Qi1" <qi1.zhang@...el.com>
Subject: Re: [PATCH] usb_wwan: some improvement on write and resume

On Sun, Apr 27, 2014 at 10:15:45AM +0800, Xiao Jin wrote:
> > They are however two distinct bugs and should be fixed separately. Could
> > you split the fixes into two patches and resubmit?
> >
> > Please also include a more descriptive subject line for each patch, for
> > example:
> >
> > 	"USB: usb_wwan: fix urb leak in write error path"
> > 	"USB: usb_wwan: fix race between write and resume"
> >
> > You should probably point out that the write-resume race could also lead
> > to writes being reordered in the description of that patch.
> >
> 
> Thanks. I will resubmit two patches.

Thanks for resending. I'll include them in the autosuspend series I'll
hopefully be able to post shortly.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/