linux-kernel - Re: [PATCH] do_mounts: fix not all available filesystems get tried during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALkh-Hg8FRkkYarcyciJVn-eB+9oNeVxRa0xX-JbxTzRgTLDXw@mail.gmail.com>
Date:	Sun, 27 Apr 2014 14:08:36 +0300
From:	Пламен Петров 
	<plamen.sisi@...il.com>
To:	Richard Weinberger <richard.weinberger@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] do_mounts: fix not all available filesystems get tried
 during boot

XFS, for one. Best see the mentioned bugzilla entries.

2014-04-27 14:04 GMT+03:00 Richard Weinberger <richard.weinberger@...il.com>:
> On Sun, Apr 27, 2014 at 12:37 PM, Пламен Петров <plamen.sisi@...il.com> wrote:
>> While debugging a kernel panic with 3.14.1 it became clear that some
>> changes made some filesystems mount routines return error codes other
>> than 0, EACCES and EINVAL. Such return codes result in the kernel
>> panicking without trying to mount root with all of the available
>> filesystems, as can be seen in bugzilla entries 74901 and 74261.
>
> What filesystems are these?
>
>> Make mount_block_root continue trying other available filesystems by
>> default, not only when the last tried returned EACCES or EINVAL.
>>
>> Signed-off-by: Plamen Petrov <plamen.sisi@...il.com>
>> ---
>>  init/do_mounts.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/init/do_mounts.c b/init/do_mounts.c
>> index 09ded58..a4abbdf 100644
>> --- a/init/do_mounts.c
>> +++ b/init/do_mounts.c
>> @@ -403,7 +403,7 @@ retry:
>>                         case -EACCES:
>>                                 flags |= MS_RDONLY;
>>                                 goto retry;
>> -                       case -EINVAL:
>> +                       default:
>>                                 continue;
>>                 }
>>                 /*
>> --
>> 1.9.0
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
>
> --
> Thanks,
> //richard



-- 
Plamen Petrov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/