linux-kernel - Re: [PATCH 2/2] staging/rtl8192e: userspace ptr deref + incorrect declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398621918.30622.6.camel@wisdom>
Date:	Sun, 27 Apr 2014 20:05:18 +0200
From:	Dominique van den Broeck <domdevlin@...e.fr>
To:	Levente Kurusa <levex@...ux.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging/rtl8192e: userspace ptr deref + incorrect
 declarations

Hello,
Thanks for your comments and reviewing.

> I guess it would be better to have defines for those instead of
> hard-coding the offsets. Also the size of the info_buf array
> might change depending on the size of wrqu->data.pointer, right?
> Maybe create a new define for that as well?
> Let's just be safe and create new defines to prevent headaches in
> the future, if not for futher expansion then for the sake of
> legibility.

As regards those hardcoded indexes, I totally agree.

Still, for this particular patch only, I tried to stick to what
was signaled by sparse. I kept the rest as it was. "info_buf",
directly pointing userspace, and its index numbers are declared
this way by the original code...

I remain totally willing to make it better. :-)

Cheers.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/