linux-kernel - Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4447051.OnJtcFSqFV@wuerfel>
Date:	Sun, 27 Apr 2014 20:23:06 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Shaik Ameer Basha <shaik.ameer@...sung.com>,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	kgene.kim@...sung.com, prathyush.k@...sung.com,
	grundler@...omium.org, joro@...tes.org,
	supash.ramaswamy@...aro.org, tomasz.figa@...il.com,
	joshi@...sung.com, sachin.kamat@...aro.org, s.nawrocki@...sung.com,
	Varun.Sethi@...escale.com, a.motakis@...tualopensystems.com,
	pullip.cho@...sung.com, t.figa@...sung.com,
	rahul.sharma@...sung.com
Subject: Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

On Sunday 27 April 2014 13:07:43 Shaik Ameer Basha wrote:
> +- mmu-masters: A phandle to device nodes representing the master for which
> +               the System MMU can provide a translation. Any additional values
> +              after the phandle will be ignored because a System MMU never
> +              have two or more masters. "#stream-id-cells" specified in the
> +              master's node will be also ignored.
> +              If more than one phandle is specified, only the first phandle
> +              will be treated.

This seems completely backwards: Why would you list the masters for an IOMMU
in the IOMMU node?

The master should have a standard property pointing to the IOMMU instead.

We don't have a generic binding for IOMMUs yet it seems, but the time is
overdue to make one.

Consider this NAKed until there is a generic binding for IOMMUs that all
relevant developers have agreed to.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/