linux-kernel - Re: [PATCH 3.8 068/133] [SCSI] fix our current target reap infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 27 Apr 2014 12:46:21 -0700
From:	Kamal Mostafa <kamal@...onical.com>
To:	Ben Hutchings <ben@...adent.org.uk>,
	Luis Henriques <luis.henriques@...onical.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	kernel-team@...ts.ubuntu.com,
	James Bottomley <JBottomley@...allels.com>
Subject: Re: [PATCH 3.8 068/133] [SCSI] fix our current target reap
 infrastructure

On Fri, 2014-04-25 at 03:03 +0100, Ben Hutchings wrote:
> On Tue, 2014-04-22 at 13:13 -0700, Kamal Mostafa wrote:
> > 3.8.13.22 -stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: James Bottomley <JBottomley@...allels.com>
> > 
> > commit e63ed0d7a98014fdfc2cfeb3f6dada313dcabb59 upstream.
> > 
> > This patch eliminates the reap_ref and replaces it with a proper kref.
> > On last put of this kref, the target is removed from visibility in
> > sysfs.  The final call to scsi_target_reap() for the device is done from
> > __scsi_remove_device() and only if the device was made visible.  This
> > ensures that the target disappears as soon as the last device is gone
> > rather than waiting until final release of the device (which is often
> > too long).
> > 
> > Reviewed-by: Alan Stern <stern@...land.harvard.edu>
> > Tested-by: Sarah Sharp <sarah.a.sharp@...ux.intel.com>
> > Signed-off-by: James Bottomley <JBottomley@...allels.com>
> > Signed-off-by: Kamal Mostafa <kamal@...onical.com>
> [...]
> 
> This and the next patch had the comment "delay backport by 2 months for
> field testing".
> 


Yup, thanks very much for catching this Ben.  I'll drop these two from
the 3.8-stable queue:

        e63ed0d [SCSI] fix our current target reap infrastructure
        f2495e2 [SCSI] dual scan thread bug fix

Luis, heads-up, looks like you have them queued for 3.11-stable too.

I note that our standard (and automated) procedure of stripping the "Cc:
stable" lines when applying to stable isn't helping us here.  Useful
hints like this advisory from those patches often just go unnoticed:

    Cc: stable@...r.kernel.org # delay backport for 2 months for field testing

I'll start thinking about how we can improve our scripts and procedures
so that we don't throw this info away.

 -Kamal


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/