linux-kernel - Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0B38703A-0903-469F-B2A3-D71E7E1D19E9@linuxhacker.ru>
Date:	Sun, 27 Apr 2014 18:19:59 -0400
From:	Oleg Drokin <green@...uxhacker.ru>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Dmitry Eremin <dmitry.eremin@...el.com>
Subject: Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

On Apr 27, 2014, at 6:05 PM, One Thousand Gnomes wrote:

>> Reviewed-by: John L. Hammond <john.hammond@...el.com>
>> Reviewed-by: Isaac Huang <he.huang@...el.com>
>> Signed-off-by: Oleg Drokin <oleg.drokin@...el.com>
>> ---
>> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>> index 21d36ee..516f623 100644
>> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>> @@ -829,14 +829,14 @@ ksocknal_select_ips(ksock_peer_t *peer, __u32 *peerips, int n_peerips)
>> 				best_npeers = iface->ksni_npeers;
>> 			}
>> 
>> +			LASSERT(best_iface != NULL);
>> +
> 
> And this solves the problem how ???

This does not really solve anything.
Just moves the check to where it's actually going to do anything instead of the check being guarded by the NULL pointer access earlier on.
Could have been removed instead of course to just get an oops at all times.--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/