linux-kernel - Re: [PATCH 1/4] acerhdf: Adding support for "manual mode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cone.1398637367.408741.1804.1000@galar>
Date:	Mon, 28 Apr 2014 00:22:47 +0200
From:	Peter Feuerer <peter@...e.net>
To:	Borislav Petkov <bp@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andreas Mohr <andi@...as.de>
Subject: Re: [PATCH 1/4] acerhdf: Adding support for
         "manual mode"

Borislav Petkov writes:

> On Sun, Apr 27, 2014 at 03:23:32AM +0200, Peter Feuerer wrote:
>> From: Peter Feuerer <peter@...e.net>
>> 
>> Some Acer models require an additional command to turn off the fan after
>> bios mode has been enabled.  Adding new section in bios table to allow
>> support for those models, by writing an extra "manual mode" register.
> 
> Why?
> 
> That command is always the same AFAICT. So why not add a single flag to
> bios_settings_t called "needs_manual" or such and then do the required
> dance in acerhdf_change_fanstate() if it is set?

I wanted to be prepared for possible upcoming models with changed registers 
/ values.  But I guess it would make sense to go for your proposal for now 
and then afterwards we should discuss about implementing the idea of 
Andreas and split the bios_tbl.


> Btw, this "struct bios_settings_t" could lose that "_t" at the end as it
> is not a typedef. We don't like typedefs anyway. :-)

True, will put this on my todo list :)

-- 
--peter;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/