linux-kernel - RE: [PATCH v2 1/5] ACPICA: OSL: Add direct inclusion of extra header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1AE640813FDE7649BE1B193DEA596E88025586C7@SHSMSX101.ccr.corp.intel.com>
Date:	Mon, 28 Apr 2014 04:12:44 +0000
From:	"Zheng, Lv" <lv.zheng@...el.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Brown, Len" <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: RE: [PATCH v2 1/5] ACPICA: OSL: Add direct inclusion of extra
 header.

Hi, Rafael

> From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> Sent: Monday, April 28, 2014 5:34 AM
> 
> On Wednesday, April 23, 2014 02:53:52 PM Lv Zheng wrote:
> > This is a linuxized result of an ACPICA commit to upgrade the extra
> > header mechanism.
> >
> > This patch enhances the extra header solution to allow Linux to use
> > ACPI_USE_NATIVE_INTERFACE_HEADER and the file name can be automatically
> > replaced during ACPICA release process. Using this way, the rest of the
> > ACPICA users needn't know the name of the extra header file. Lv Zheng.
> >
> > Signed-off-by: Lv Zheng <lv.zheng@...el.com>
> > ---
> >  include/acpi/acpi.h |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/acpi/acpi.h b/include/acpi/acpi.h
> > index ca0cb60..682398b 100644
> > --- a/include/acpi/acpi.h
> > +++ b/include/acpi/acpi.h
> > @@ -62,8 +62,8 @@
> >  #include <acpi/acrestyp.h>		/* Resource Descriptor structs */
> >  #include <acpi/acpiosxf.h>		/* OSL interfaces (ACPICA-to-OS) */
> >  #include <acpi/acpixf.h>		/* ACPI core subsystem external interfaces */
> > -#ifdef ACPI_NATIVE_INTERFACE_HEADER
> > -#include ACPI_NATIVE_INTERFACE_HEADER
> > +#ifdef ACPI_USE_NATIVE_INTERFACE_HEADER
> > +#include <acpi/acpi_opt.h>
> >  #endif
> >
> >  #endif				/* __ACPI_H__ */
> 
> Well, I still think there's a better way.
> 
> Introduce <acpi/platform/acenvex.h> into ACPICA and put this into it:
> 
> #if defined(_LINUX) || defined(__linux__)
> #include <acpi/platform/aclinuxex.h>
> 
> #endif
> 
> and then move stuff you want in acpi/acpi_opt.h into acpi/platform/aclinuxex.h.
> 
> Then, you'll have in acpi.h:
> 
> #include <acpi/acrestyp.h>		/* Resource Descriptor structs */
> #include <acpi/acpiosxf.h>		/* OSL interfaces (ACPICA-to-OS) */
> #include <acpi/acpixf.h>		/* ACPI core subsystem external interfaces */
> #include <acpi/platform/acenvex.h>	/* Extra environment-specific items */
> 
> 
> That should work I suppose, shouldn't it?

I think this should work.
I'll modify this patch according the above suggestion.

Thanks and best regards
-Lv

> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.