linux-kernel - Re: [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <535E15C2.8080203@redhat.com>
Date:	Mon, 28 Apr 2014 09:48:02 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Fabian Frederick <fabf@...net.be>,
	linux-kernel <linux-kernel@...r.kernel.org>
CC:	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers

Hi,

On 26/04/14 19:57, Fabian Frederick wrote:
> Sparse warning: fs/gfs2/lops.c:78:29:
> "warning: Using plain integer as NULL pointer"
>
> Cc: Steven Whitehouse <swhiteho@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>   fs/gfs2/lops.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Now in the GFS2 -nmw tree. Thanks,

Steve.

> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index a294d8d..2c1ae86 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -75,7 +75,7 @@ static void maybe_release_space(struct gfs2_bufdata *bd)
>   	unsigned int index = bd->bd_bh->b_blocknr - gl->gl_name.ln_number;
>   	struct gfs2_bitmap *bi = rgd->rd_bits + index;
>   
> -	if (bi->bi_clone == 0)
> +	if (bi->bi_clone == NULL)
>   		return;
>   	if (sdp->sd_args.ar_discard)
>   		gfs2_rgrp_send_discards(sdp, rgd->rd_data0, bd->bd_bh, bi, 1, NULL);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/