linux-kernel - Re: [PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140428092523.GS26890@mwanda>
Date:	Mon, 28 Apr 2014 12:25:23 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	navin patidar <navin.patidar@...il.com>
Cc:	gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Use USB subsystem functions to check
 endpoint type

On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote:
> Use inline functions provided by USB subsystem to check endpoint type,
> instead of macros implemented by driver to do the same.
> 
> Unnecessary debugging messages are also removed.
> 

I like both these changes but they would have been so much easier to
review if you deleted the debugging messagese in [patch 1/2] and then
changed the endpoint functions in [patch 2/2].

> @@ -183,60 +143,36 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
>  	pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;
>  
>  	for (i = 0; i < pdvobjpriv->nr_endpoint; i++) {
> +

Don't put a blank line here, btw.

> +		int ep_num;
>  		phost_endp = phost_iface->endpoint + i;

Anyway, please resend because it needs to be broken into two patches.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/