linux-kernel - Re: [PATCH] staging: silicom: Remove unused pointer in bypass_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2014 12:30:29 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Christian Engelmayer <cengelma@....at>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	rashika.kheria@...il.com, linux-kernel@...r.kernel.org,
	tulinizer@...il.com, michael.banken@...he.stud.uni-erlangen.de,
	andriy.shevchenko@...ux.intel.com, lorenz@...gers.com
Subject: Re: [PATCH] staging: silicom: Remove unused pointer in
 bypass_init_module()

On Sat, Apr 26, 2014 at 10:15:04PM +0200, Christian Engelmayer wrote:
> Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused.
> Thus remove it.
> 
> Signed-off-by: Christian Engelmayer <cengelma@....at>
> ---
> Compile tested and applies against v3.15-rc2 as well as branch staging-next
> of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> ---
>  drivers/staging/silicom/bpctl_mod.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
> index 7f3d884..2bf8964 100644
> --- a/drivers/staging/silicom/bpctl_mod.c
> +++ b/drivers/staging/silicom/bpctl_mod.c
> @@ -6372,13 +6372,10 @@ static int __init bypass_init_module(void)
>  	sema_init(&bpctl_sema, 1);
>  	spin_lock_init(&bpvm_lock);
>  	{
> -
> -		struct bpctl_dev *pbpctl_dev_c = NULL;

The code is indented so that it can do that declaration.  Now the you
have removed the declaration, please remove the indent block '{' as
well.

This still falls under the one thing per patch rule because fixing the
indenting and removing the unused declaration are closely related.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/