linux-kernel - Re: [PATCH] sound: core: Fix format string mismatch in seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h1twhdaem.wl%tiwai@suse.de>
Date:	Mon, 28 Apr 2014 12:18:57 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Masanari Iida <standby24x7@...il.com>
Cc:	perex@...ex.cz, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] sound: core: Fix format string mismatch in seq_midi.c

At Tue, 22 Apr 2014 20:42:05 +0900,
Masanari Iida wrote:
> 
> Fix format string mismatch in snd_seq_midisynth_register_port().
> Argument type of p is unsigned int.
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>

Thanks, applied.


Takashi

> ---
>  sound/core/seq/seq_midi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/seq/seq_midi.c b/sound/core/seq/seq_midi.c
> index 3e05c55..a1fd77a 100644
> --- a/sound/core/seq/seq_midi.c
> +++ b/sound/core/seq/seq_midi.c
> @@ -362,13 +362,13 @@ snd_seq_midisynth_register_port(struct snd_seq_device *dev)
>  		if (! port->name[0]) {
>  			if (info->name[0]) {
>  				if (ports > 1)
> -					snprintf(port->name, sizeof(port->name), "%s-%d", info->name, p);
> +					snprintf(port->name, sizeof(port->name), "%s-%u", info->name, p);
>  				else
>  					snprintf(port->name, sizeof(port->name), "%s", info->name);
>  			} else {
>  				/* last resort */
>  				if (ports > 1)
> -					sprintf(port->name, "MIDI %d-%d-%d", card->number, device, p);
> +					sprintf(port->name, "MIDI %d-%d-%u", card->number, device, p);
>  				else
>  					sprintf(port->name, "MIDI %d-%d", card->number, device);
>  			}
> -- 
> 2.0.0.rc0.26.g779792a
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/