linux-kernel - Re: [PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2014 13:07:32 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Tim Kryger <tim.kryger@...aro.org>
Cc:	Matt Porter <mporter@...aro.org>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Christian Daudt <bcm@...thebug.org>,
	Grant Likely <grant.likely@...aro.org>,
	Linux PWM List <linux-pwm@...r.kernel.org>,
	Device Tree List <devicetree@...r.kernel.org>,
	Linux Doc List <linux-doc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Broadcom Kernel Feedback List 
	<bcm-kernel-feedback-list@...adcom.com>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

On Fri, Apr 25, 2014 at 11:31:10AM -0700, Tim Kryger wrote:
> This series introduces the driver for the Kona PWM controller found in
> Broadcom mobile SoCs like bcm281xx and updates the device tree and the
> defconfig to enable use of this hardware on the bcm28155 AP board.
> 
> Changes since v5:
>   - Rebased on v3.15-rc1
> 
> Changes since v4:
>   - Added in real polarity support
>   - Labeled trigger bits as such rather than use the name from hw docs
>   - Listed unsual hardware characteristics at the top of the file
>   - Removed default from Kconfig and update defconfig accordingly
>   - Always use unsigned int for temporary register values
> 
> Changes since v3:
>   - Removed polarity support for now
>   - Cleaned up whitespace issues, shortened some variable names
>   - Use container_of instead of dev_get_drvdata to get private data
>   - Removed workaround for PWM framework bug
>   - Reworded some binding documentation
> 
> Changes since v2:
>   - SoC DTS file updated to use real clock's phandle + specifier
>   - Toggle smooth mode off during apply so new settings take immediately
> 
> Changes since v1:
>   - Fixed up macros to be clearer and more complete
>   - Corrected spelling and punctuation mistakes
>   - Added support for polarity
>   - Made peripheral clock use more efficient
>   - Made prescale and duty computation clearer
>   - Moved Makefile addition to keep alphabetical
>   - Split complex lines into multiple steps
> 
> 
> Tim Kryger (5):
>   Documentation: dt: Add Kona PWM binding
>   pwm: kona: Introduce Kona PWM controller support
>   ARM: dts: Declare the PWM for bcm11351 (bcm281xx)
>   ARM: dts: Enable the PWM for bcm28155 AP board
>   ARM: bcm_defconfig: Enable PWM and Backlight
> 
>  .../devicetree/bindings/pwm/bcm-kona-pwm.txt       |   21 ++
>  arch/arm/boot/dts/bcm11351.dtsi                    |    8 +
>  arch/arm/boot/dts/bcm28155-ap.dts                  |    4 +
>  arch/arm/configs/bcm_defconfig                     |    3 +
>  drivers/pwm/Kconfig                                |    9 +
>  drivers/pwm/Makefile                               |    1 +
>  drivers/pwm/pwm-bcm-kona.c                         |  319 ++++++++++++++++++++
>  7 files changed, 365 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt
>  create mode 100644 drivers/pwm/pwm-bcm-kona.c

I've applied patches 1 and 2 (with two tiny whitespace cleanups) to my
for-next branch.

Thanks,
Thierry

Content of type "application/pgp-signature" skipped