linux-kernel - Re: [PATCH V2 1/2] FS: Add generic data flush to fsync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140428114927.GB9522@infradead.org>
Date:	Mon, 28 Apr 2014 04:49:27 -0700
From:	hch <hch@...radead.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, jack <jack@...e.cz>,
	hch <hch@...radead.org>, Viro <viro@...iv.linux.org.uk>,
	tytso <tytso@....edu>, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH V2 1/2] FS: Add generic data flush to fsync

> +	if (flush == true) {
> +		err = blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL,
> +					 NULL);
> +		if (ret == 0)
> +			ret = err;
> +	}
> +
>  out:
>  	mutex_unlock(&inode->i_mutex);

There is no need to have the cache flush under i_mutex, and thus there's
also no need to have the parameter, as the flush can be done in
generic_file_fsync.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/