linux-kernel - Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpRwGSgR1by+7TEa=Ec7cQ1v4qYhJuLkv785z2NxORBUQ@mail.gmail.com>
Date:	Mon, 28 Apr 2014 16:11:30 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	micky <micky_ching@...lsil.com.cn>, Chris Ball <chris@...ntf.net>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...uxdriverproject.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Roger <rogerable@...ltek.com>, Wei WANG <wei_wang@...lsil.com.cn>
Subject: Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

On 28 April 2014 14:29, Lee Jones <lee.jones@...aro.org> wrote:
>> >> From: Micky Ching <micky_ching@...lsil.com.cn>
>> >>
>> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
>> >
>> > Why was this patch even merged without an MFD Ack?
>> >
>> >> commit <mmc: rtsx: add support for pre_req and post_req> did use
>> >> mutex_unlock() in tasklet, but mutex_unlock() can't used in
>> >> tasklet(atomic context). The driver need use mutex to avoid concurrency,
>> >> so we can't use tasklet here, the patch need to be removed.
>> >>
>> >> The spinlock host->lock and pcr->lock may deadlock, one way to solve the
>> >> deadlock is remove host->lock in sd_isr_done_transfer(), but if using
>> >> workqueue the we can avoid using the spinlock and also avoid the problem.
>> >>
>> >> Signed-off-by: Micky Ching <micky_ching@...lsil.com.cn>
>> >> ---
>> >>  drivers/mfd/rtsx_pcr.c            |  132 ++++--------
>> >>  drivers/mmc/host/rtsx_pci_sdmmc.c |  418 ++++++-------------------------------
>> >>  include/linux/mfd/rtsx_common.h   |    1 -
>> >>  include/linux/mfd/rtsx_pci.h      |    6 -
>> >>  4 files changed, 109 insertions(+), 448 deletions(-)
>> >
>> > This patch should be sent to the -rcs as soon as possible:
>>
>> Do you mind helping out doing it here Lee? Not sure how busy Chris is
>> at the moment.
>
> I don't mind. I just need a maintainer Ack from one of you guys.

Thanks for helping out Lee. Please hold on until we sorted out exactly
what should be reverted, it seems like some additional patch should be
removed/reverted as well.

Kind regards
Uffe

>
>> >
>> > Acked-by: Lee Jones <lee.jones@...aro.org>
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/