linux-kernel - Re: [PATCH V3] Add support for flag status register on Micron chips.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2014 09:22:58 -0500
From:	Graham Moore <ggrahammoore@...il.com>
To:	Huang Shijie <b32955@...escale.com>
Cc:	Marek Vasut <marex@...x.de>, Huang Shijie <shijie8@...il.com>,
	Graham Moore <grmoore@...era.com>,
	Geert Uytterhoeven <geert+renesas@...ux-m68k.org>,
	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Jingoo Han <jg1.han@...sung.com>, linux-kernel@...r.kernel.org,
	Yves Vandervennet <rocket.yvanderv@...il.com>,
	linux-mtd@...ts.infradead.org,
	Insop Song <insop.song@...nspeed.com>,
	Alan Tull <atull@...era.com>,
	Sourav Poddar <sourav.poddar@...com>,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Dinh Nguyen <dinguyen@...era.com>
Subject: Re: [PATCH V3] Add support for flag status register on Micron chips.

On Mon, Apr 28, 2014 at 2:06 AM, Huang Shijie <b32955@...escale.com> wrote:
> On Mon, Apr 28, 2014 at 07:06:17AM +0200, Marek Vasut wrote:
>>
>> Two things competing over the same pointer looks misdesigned to me. I will need
>> to dig into this one more time ...
> Please refer to the code for NAND chip, the nand_get_flash_type() :
>
> -----------------------------------------------------------
>         /* Do not replace user supplied command function! */
>         if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
>                 chip->cmdfunc = nand_command_lp;
> -----------------------------------------------------------
>
> It uses the same logic:
>         " Do not replace user supplied command function!"
>
> thanks
> Huang Shijie

I would like to set the @wait_till_ready in m25p80.c, because the
USE_FSR flag is only for Micron chips.  But the m25p80 driver doesn't
have access to the flags, they are contained in spi-nor.c.  It seems
to me that the driver_data should be accessible by the driver.  So
maybe there is room for improvement there.

Thanks,
Graham Moore
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/