linux-kernel - Re: [PATCH] ARM: l2c: prima2: only call l2x0_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140428145223.GL26756@n2100.arm.linux.org.uk>
Date:	Mon, 28 Apr 2014 15:52:23 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Matt Porter <mporter@...aro.org>
Cc:	Felipe Balbi <balbi@...com>, Barry Song <baohua@...nel.org>,
	Kevin Hilman <khilman@...aro.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching
	nodes

On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt Porter wrote:
> The "fix" is tested against bcm281xx and bcm21664 as that is what the
> l2c cleanup breaks in -next. As mentioned, I don't have the sirfsoc h/w
> so this first attempt at a fix also breaks their platform. It can be
> addressed by adding those platform specific compatibles back to the dts,
> of course.
> 
> I'd much prefer that the sirfsoc folks fix this...it's going to break
> other platforms in a multi v7 build.

Well, it's about time we got rid of this from platform specific code
anyway, taking it away from platform maintainers to mess around with.
So that's what I'm doing.

It's worth noting that if you build a single zImage with exynos also
enabled, then you also end up with an unconditional call from that
code to l2x0_of_init() with it's own magic numbers - and that applies
before my changes.

So let's fix this properly and yank this crap from platform maintainers
fingers.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/