linux-kernel - Re: Updated asmlinkage patch v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140428151721.GE2641@moskyto.dyndns.org>
Date:	Mon, 28 Apr 2014 17:17:21 +0200
From:	Jan Moskyto Matejka <mq@...e.cz>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	the arch/x86 maintainers <x86@...nel.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: Updated asmlinkage patch v2

> On Tue, Apr 1, 2014 at 2:40 PM, Andi Kleen <andi@...stfloor.org> wrote:
> >
> > Did some basic sanity checks with LTO and everything
> > works (still need the three other LTO patches to build)
> 
> Ok, this series looks much better. Thanks,

It seems this series hasn't made it to the torvalds tree yet so the
compiler still issues complaints about __visible static functions.
Should I bring a patch removing the "static" from asmlinkage-annotated
functions, or is this patch the better way? Or have I missed something?

BTW some of the functions have already lost their asmlinkage, see
commit 8783dd3a37a5853689e1a8fa728827a50905b912 ("irqchip: Remove
asmlinkage from static functions") in torvalds tree and also recent
thread https://lkml.org/lkml/2014/4/16/453 ("[PATCH] crypto:
sha{256,512}_ssse3 - remove asmlinkage from static functions"), both of
them because "it issues warnings".

MQ

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)