linux-kernel - Re: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2014 13:10:41 -0300
From:	Guido Martínez <guido@...guardiasur.com.ar>
To:	George Cherian <george.cherian@...com>
Cc:	LKML <linux-kernel@...r.kernel.org>, bcousson@...libre.com,
	tony@...mide.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, linux@....linux.org.uk,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Ezequiel García 
	<ezequiel@...guardiasur.com.ar>
Subject: Re: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB
 and DMA refs

On Mon, Apr 28, 2014 at 08:11:33PM +0530, George Cherian wrote:
> On 4/28/2014 7:28 PM, Guido Martínez wrote:
> >Use phandles instead of unit adresses to reference usb and dma nodes.
> >This makes the DT more robust and readable.
> The series will give dtb build errors
> Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
> FATAL ERROR: Unable to parse input tree
> Error: arch/arm/boot/dts/am335x-evmsk.dts:367.2-15 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [arch/arm/boot/dts/am335x-bone.dtb] Error 1
> make[1]: *** Waiting for unfinished jobs....
> Error: arch/arm/boot/dts/am335x-evm.dts:334.2-15 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [arch/arm/boot/dts/am335x-evmsk.dtb] Error 1
> make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1
> Error: arch/arm/boot/dts/am335x-igep0033.dtsi:204.2-15 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [arch/arm/boot/dts/am335x-base0033.dtb] Error 1
> Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [arch/arm/boot/dts/am335x-boneblack.dtb] Error 1
> make: *** [dtbs] Error 2
> 
Terribly sorry about this. I'll send a v2.

> >
> >Signed-off-by: Guido Martínez <guido@...guardiasur.com.ar>
> >---
> >  arch/arm/boot/dts/am335x-bone-common.dtsi | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> >diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> >index 2e7d932..b95bc9a 100644
> >--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> >+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> >@@ -183,28 +183,28 @@
> >  &usb {
> >  	status = "okay";
> >-	control@...10620 {
> >+	&usb_ctrl_mod {
> >  		status = "okay";
> >  	};
> >-	usb-phy@...01300 {
> >+	&usb0_phy {
> >  		status = "okay";
> >  	};
> >-	usb-phy@...01b00 {
> >+	&usb1_phy {
> >  		status = "okay";
> >  	};
> >-	usb@...01000 {
> >+	&usb0 {
> >  		status = "okay";
> >  	};
> >-	usb@...01800 {
> >+	&usb1 {
> >  		status = "okay";
> >  		dr_mode = "host";
> >  	};
> >-	dma-controller@...02000  {
> >+	&cppi41dma  {
> >  		status = "okay";
> >  	};
> >  };
> Instead the patch should be
> 
>      diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
> b/arch/arm/boot/dts/am335x-bone-common.dtsi
>      index 2e7d932..06be20a 100644
>      --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>      +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>      @@ -182,31 +182,30 @@
> 
>       &usb {
>              status = "okay";
>      +};
>      +&usb_ctrl_mod {
>      +       status = "okay";
>      +};
> 
>      -       control@...10620 {
>      -               status = "okay";
>      -       };
>      -
>      -       usb-phy@...01300 {
>      -               status = "okay";
>      -       };
>      +&usb0_phy {
>      +       status = "okay";
>      +};
> 
>      -       usb-phy@...01b00 {
>      -               status = "okay";
>      -       };
>      +&usb1_phy {
>      +       status = "okay";
>      +};
> 
>      -       usb@...01000 {
>      -               status = "okay";
>      -       };
>      +&usb {
>      +       status = "okay";
>      +};
> 
>      -       usb@...01800 {
>      -               status = "okay";
>      -               dr_mode = "host";
>      -       };
>      +&usb1 {
>      +       status = "okay";
>      +       dr_mode = "host";
>      +};
> 
>      -       dma-controller@...02000  {
>      -               status = "okay";
>      -       };
>      +&cppi41dma  {
>      +       status = "okay";
>       };
> 
> 
> 
> -- 
> -George
> 

-- 
Guido Martínez, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/