linux-kernel - Re: [PATCH 1/3] driver core & of: Mark of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398707451.20390.14.camel@hornet>
Date:	Mon, 28 Apr 2014 18:50:51 +0100
From:	Pawel Moll <pawel.moll@....com>
To:	Rob Herring <robherring2@...il.com>
Cc:	Mark Rutland <mark.rutland@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Arnd Bergmann <arnd@...db.de>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arm@...nel.org" <arm@...nel.org>, Jean Delvare <jdelvare@...e.de>,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	lm-sensors@...sensors.org, Lee Jones <lee.jones@...aro.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Guenter Roeck <linux@...ck-us.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/3] driver core & of: Mark of_nodes of added device as
 populated

On Mon, 2014-04-28 at 18:37 +0100, Pawel Moll wrote:
> On Thu, 2014-02-13 at 13:15 -0600, Rob Herring wrote:
> > On Tue, Feb 11, 2014 at 10:53 AM, Pawel Moll <pawel.moll@....com> wrote:
> > > In "Device Tree powered" systems, platform devices are usually
> > > massively populated with of_platform_populate() call, executed
> > > at some level of initcalls, either by generic architecture
> > > or by platform-specific code.
> >
> > Go read Grant's and my comments from your last posting.
> 
> Right, I can't explain why I missed those. Will do right now.

Actually I can't seem to find it in my mail archive, but I remember you
were saying that it shouldn't spoil into the driver base code. You're
probably right, so the updated patch will be limited to of_platform_*
API.

Grant was suggesting that I shouldn't be using the device model if I
have to initialize some early stuff. The thing is that my stuff is not
that early at all. The device model works for me perfectly, as long as I
can initialize 3 crucial devices in a correct order (and *then* do mass
population). And the init levels are perfect for this job. The only
thing I need is a small refinement in the way DT-based devices are
populated and this is exactly what I propose. Hope it makes more sense
now.

Cheers!

Pawel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/