linux-kernel - Re: [Patch V2 1/9] ACPICA: Executer: Fix buffer allocation issue for generic_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398707520.2843.16.camel@adam.happyassassin.net>
Date:	Mon, 28 Apr 2014 10:52:00 -0700
From:	Adam Williamson <awilliam@...hat.com>
To:	Lan Tianyu <tianyu.lan@...el.com>
Cc:	wsa@...-dreams.de, rjw@...ysocki.net,
	mika.westerberg@...ux.intel.com, lenb@...nel.org,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, Lv Zheng <lv.zheng@...el.com>
Subject: Re: [Patch V2 1/9] ACPICA: Executer: Fix buffer allocation issue
 for generic_serial_bus region field accesses.

On Mon, 2014-04-28 at 22:27 +0800, Lan Tianyu wrote:
> From: Lv Zheng <lv.zheng@...el.com>
> 
> The size of the buffer allocated for generic_serial_bus region access
> is not correct.  This patch introduces acpi_ex_get_serial_access_length()
> to be invoked to obtain correct data buffer length.  Reported by
> Lan Tianyu, Fixed by Lv Zheng.
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Signed-off-by: Lv Zheng <lv.zheng@...el.com>
> Signed-off-by: Lan Tianyu <tianyu.lan@...el.com>

Very superficial issue, and sorry I forgot to mention it for v1, but the
summary line for this patch (1/9) ends with a period - "...region field
accesses." - which I think is not the correct style?
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/