lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Date:	Mon, 28 Apr 2014 22:57:39 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Hartley Sweeten <HartleyS@...ionengravers.com>,
	Chase Southwood <chase.southwood@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] staging: comedi: addi_apci_1032: board has 32 digital
 inputs

On 28/04/14 19:11, Hartley Sweeten wrote:
> On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
>> This board always has 32 digital inputs. Remove the test when
>> initializing the subdevice.
>>
>> Also, since this board is the only one supported by this driver,
>> remove the boardinfo about the digital inputs and just use the
>> data directly in the subdevice init.
>>
>> Signed-off-by: Chase Southwood <chase.southwood@...il.com>
>> Cc: Ian Abbott <abbotti@....co.uk>
>> Cc: H Hartley Sweeten <hsweeten@...ionengravers.com>
>> ---
>>   drivers/staging/comedi/drivers/addi_apci_1564.c | 26 +++++++++----------------
>>   1 file changed, 9 insertions(+), 17 deletions(-)
>
> Looks good.

Apart from the subject not matching the patch!

(I would have replied to the original, but I seem to have mislaid it.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ