linux-kernel - Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140429080240.GC29462@lee--X1>
Date:	Tue, 29 Apr 2014 09:02:40 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	micky_ching@...lsil.com.cn
Cc:	chris@...ntf.net, ulf.hansson@...aro.org, sameo@...ux.intel.com,
	gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org, rogerable@...ltek.com,
	wei_wang@...lsil.com.cn
Subject: Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request

> From: Micky Ching <micky_ching@...lsil.com.cn>
> 
> The commit <mmc: rtsx: add support for pre_req and post_req> have some problem,
> using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix
> these problem, and better to use a new method. So just remove it.
> 
> The commit <mmc: rtsx: modify error handle and remove smatch warnings> depends
> on the previous patch. And mainly fix some problem for the previous patch. So
> need remove.
> 
> Micky Ching (2):
>   mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch
>     warnings"
>   mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"
> 
>  drivers/mfd/rtsx_pcr.c            |  132 ++++-------
>  drivers/mmc/host/rtsx_pci_sdmmc.c |  459 +++++++------------------------------
>  include/linux/mfd/rtsx_common.h   |    1 -
>  include/linux/mfd/rtsx_pci.h      |    6 -
>  4 files changed, 124 insertions(+), 474 deletions(-)

Just to clarify, what commit did you base these changes on? Have you
tested to ensure everything works as it should with these two
reversions?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/