linux-kernel - Re: lockdep warning after recent cleanup in console code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140428141439.3580dce9@gandalf.local.home>
Date:	Mon, 28 Apr 2014 14:14:39 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jan Kara <jack@...e.cz>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: lockdep warning after recent cleanup in console code

On Mon, 28 Apr 2014 19:51:39 +0200
Jan Kara <jack@...e.cz> wrote:

> On Mon 28-04-14 13:43:31, Steven Rostedt wrote:
> > Things have changed with regard to printk() in linux-next. Now it
> > appears that lockdep is going haywire over it. I don't understand the
> > exact reason for the lockdep_off() and lockdep_on() logic that is in
> > printk(), but it obviously seems to be causing issues with the new
> > changes.
> > 
> > Care to take a look?
>   The obvious cause is that I moved lockdep_on() somewhat earlier in
> vprintk_emit() so lockdep now covers more of printk code. And apparently
> something is wrong there...
> 

Exactly, and I rather know *exactly* what is wrong before we just start
throwing patches at the problem and hope it goes away. That's not how
to solve a software bug.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/