lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20140429093136.GA10359@devel>
Date:	Tue, 29 Apr 2014 18:31:37 +0900
From:	Daeseok Youn <daeseok.youn@...il.com>
To:	axboe@...com
Cc:	b.zolnierkie@...sung.com, kyungmin.park@...sung.com,
	agordeev@...hat.com, bhansaliakhil@...il.com,
	rchinthekindi@...c-inc.com, snitzer@...hat.com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] skd: remove redundant null check for kfree()

smatch says:
 skd_acquire_msix() info: redundant null check
on entries calling kfree()

Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
---
 drivers/block/skd_main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 608532d..fac4c08 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev)
 	return 0;
 
 msix_out:
-	if (entries)
-		kfree(entries);
+	kfree(entries);
 	skd_release_msix(skdev);
 	return rc;
 }
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ