linux-kernel - Re: OFD ("file private") locks and NFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140429071153.176c7404@tlielax.poochiereds.net>
Date:	Tue, 29 Apr 2014 07:11:53 -0400
From:	Jeff Layton <jlayton@...chiereds.net>
To:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
Cc:	Ganesha NFS List <nfs-ganesha-devel@...ts.sourceforge.net>,
	lkml <linux-kernel@...r.kernel.org>,
	Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
	Trond Myklebust <trond.myklebust@....uio.no>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Neil Brown <neilb@...e.de>, samba-technical@...ts.samba.org,
	linux-nfs@...r.kernel.org
Subject: Re: OFD ("file private") locks and NFS

On Tue, 29 Apr 2014 10:47:07 +0200
"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com> wrote:

> [CC+= linux-nfs@]
> 
> On 04/29/2014 10:38 AM, Michael Kerrisk (man-pages) wrote:
> > Hi Jeff,
> > 
> > I've been looking a bit at the fcntl() documentation of traditional 
> > (F_SETLK) record locking, and a question just jumped out at me. Is 
> > it worth considering some future-proofing in the design of OFD locks
> > ("open file description locks", formerly known as "file-private locks")?
> > 
> > What I am thinking of here is that on some systems, the traditional
> > 'struct flock' has a nonstandard field, l_sysid, that is used on F_GETLK 
> > to identify the remote system on which a lock is held. Should the design
> > of OFD locks allow for such a field (now, or in the future), which might 
> > be useful in the context of locking on network file systems such as NFS.
> > 
> > Put more simply, should the new OFD locking system be using a new
> > structure for describing locks, rather than the traditional 'struct
> > flock'? Defining a new structure, might be useful to allow for
> > future extensions to the API.
> 
> Just add one further detail here. What I'm thinking is, maybe instead there
> should be something like:
> 
> struct flockx {
>     int flags;
>     /* Other fields like 'struct flock' */
>     char reserved[32];	/* Or some suitable value */
> }
> 
> That flags field might always be zero for now, but in the future it 
> could be used on the setlk and getlk operations to indicate the presence
> of additional fields in the structure.
> 
> Cheers,
> 
> Michael
> 

I considered that early on when I did this, but I don't think it's
really helpful. I'm just not a fan of padding out structs when it's not
clear what would eventually go in there.

The problem is that once actually go to try to convert those from
"reserved" to something usable, it becomes a nightmare for userland to
figure that out. How do I know whether my kernel supports the stuff I
put in those fields or will just ignore them?

If we really find later that we need to do something like this, I think
we'd be better off adding a new set of cmd values along with the
"extended" struct, or possibly a new syscall. Some of the samba folks
were interested in an async locking mechanism too, so something like
that could be added in conjunction with such an interface.

-- 
Jeff Layton <jlayton@...chiereds.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/