linux-kernel - Re: [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets if they are not done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2014 10:25:05 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	<linux-kernel@...r.kernel.org>,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Carsten Emde <C.Emde@...dl.org>,
	John Kacur <jkacur@...hat.com>, <stable-rt@...r.kernel.org>
Subject: Re: [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets
 if they are not done

On Tue, 29 Apr 2014 10:16:51 -0400
Paul Gortmaker <paul.gortmaker@...driver.com> wrote:

 
> Sanity boot tested the 3.10 rc1 on a sbc8548 (UP PPC with gianfar), with
> the one-liner added as follows:
> 
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> index 8aecc1d81395..b87a8c919c3e 100644
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -2574,6 +2574,7 @@ static int gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue)
>         tx_queue->dirty_tx = bdp;
>  
>         netdev_tx_completed_queue(txq, howmany, bytes_sent);
> +       return howmany;

That's the change I added to 3.10-rc2. I'll post it soon if you want to
test it.

-- Steve

>  }
>  
>  static void gfar_schedule_cleanup(struct gfar_priv_grp *gfargrp)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/