linux-kernel - RE: [PATCH] mm,writeback: fix divide by zero in pos_ratio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6B2BA408B38BA1478B473C31C3D2074E31D4C5C3BB@SV-EXCHANGE1.Corp.FC.LOCAL>
Date:	Tue, 29 Apr 2014 12:43:54 -0700
From:	Motohiro Kosaki <Motohiro.Kosaki@...fujitsu.com>
To:	Rik van Riel <riel@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"sandeen@...hat.com" <sandeen@...hat.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"jweiner@...hat.com" <jweiner@...hat.com>,
	Motohiro Kosaki JP <kosaki.motohiro@...fujitsu.com>,
	"mhocko@...e.cz" <mhocko@...e.cz>,
	"fengguang.wu@...el.com" <fengguang.wu@...el.com>,
	"mpatlasov@...allels.com" <mpatlasov@...allels.com>
Subject: RE: [PATCH] mm,writeback: fix divide by zero in pos_ratio_polynom



> -----Original Message-----
> From: Rik van Riel [mailto:riel@...hat.com]
> Sent: Tuesday, April 29, 2014 3:19 PM
> To: linux-kernel@...r.kernel.org
> Cc: linux-mm@...ck.org; sandeen@...hat.com; akpm@...ux-foundation.org; jweiner@...hat.com; Motohiro Kosaki JP;
> mhocko@...e.cz; fengguang.wu@...el.com; mpatlasov@...allels.com
> Subject: [PATCH] mm,writeback: fix divide by zero in pos_ratio_polynom
> 
> It is possible for "limit - setpoint + 1" to equal zero, leading to a divide by zero error. Blindly adding 1 to "limit - setpoint" is not working,
> so we need to actually test the divisor before calling div64.
> 
> Signed-off-by: Rik van Riel <riel@...hat.com>
> Cc: stable@...r.kernel.org

Fairly obvious fix.

Acked-by: KOSAKI Motohiro <Kosaki.motohiro@...fujitsu.com>


> ---
>  mm/page-writeback.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c index ef41349..2682516 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -597,11 +597,16 @@ static inline long long pos_ratio_polynom(unsigned long setpoint,
>  					  unsigned long dirty,
>  					  unsigned long limit)
>  {
> +	unsigned int divisor;
>  	long long pos_ratio;
>  	long x;
> 
> +	divisor = limit - setpoint;
> +	if (!divisor)
> +		divisor = 1;
> +
>  	x = div_s64(((s64)setpoint - (s64)dirty) << RATELIMIT_CALC_SHIFT,
> -		    limit - setpoint + 1);
> +		    divisor);
>  	pos_ratio = x;
>  	pos_ratio = pos_ratio * x >> RATELIMIT_CALC_SHIFT;
>  	pos_ratio = pos_ratio * x >> RATELIMIT_CALC_SHIFT;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/