linux-kernel - Re: [PATCH v4 1/7] arm64: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vnkwsioveuwk.fsf@mitchelh-linux.qualcomm.com>
Date:	Tue, 29 Apr 2014 13:35:23 -0700
From:	Mitchel Humpherys <mitchelh@...eaurora.org>
To:	Jungseok Lee <jays.lee@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
	Catalin.Marinas@....com, Marc Zyngier <Marc.Zyngier@....com>,
	Christoffer Dall <christoffer.dall@...aro.org>,
	kgene.kim@...sung.com, steve.capper@...aro.org,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	ilho215.lee@...sung.com,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	sungjinn.chung@...sung.com
Subject: Re: [PATCH v4 1/7] arm64: Use pr_* instead of printk

On Mon, Apr 28 2014 at 09:59:14 PM, Jungseok Lee <jays.lee@...sung.com> wrote:
> This patch fixed the following checkpatch complaint as using pr_*
> instead of printk.
>
> WARNING: printk() should include KERN_ facility level
>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Jungseok Lee <jays.lee@...sung.com>
> Reviewed-by: Sungjinn Chung <sungjinn.chung@...sung.com>
> ---
>  arch/arm64/kernel/traps.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
> index 7ffaddd..0484e81 100644
> --- a/arch/arm64/kernel/traps.c
> +++ b/arch/arm64/kernel/traps.c
> @@ -65,7 +65,7 @@ static void dump_mem(const char *lvl, const char *str, unsigned long bottom,
>  	fs = get_fs();
>  	set_fs(KERNEL_DS);
>  
> -	printk("%s%s(0x%016lx to 0x%016lx)\n", lvl, str, bottom, top);
> +	pr_emerg("%s%s(0x%016lx to 0x%016lx)\n", lvl, str, bottom, top);

Currently this printk is being called with lvl=KERN_EMERG or lvl="". In
the case of lvl=KERN_EMERG leaving lvl in is redundant. In the case of
lvl="" this is a behavioral change (printing to a different log
level). Was this intended?

>  
>  	for (first = bottom & ~31; first < top; first += 32) {
>  		unsigned long p;
> @@ -83,7 +83,7 @@ static void dump_mem(const char *lvl, const char *str, unsigned long bottom,
>  					sprintf(str + i * 9, " ????????");
>  			}
>  		}
> -		printk("%s%04lx:%s\n", lvl, first & 0xffff, str);
> +		pr_emerg("%s%04lx:%s\n", lvl, first & 0xffff, str);

Ditto

>  	}
>  
>  	set_fs(fs);
> @@ -124,7 +124,7 @@ static void dump_instr(const char *lvl, struct pt_regs *regs)
>  			break;
>  		}
>  	}
> -	printk("%sCode: %s\n", lvl, str);
> +	pr_emerg("%sCode: %s\n", lvl, str);

Ditto. Also called with with lvl=KERN_INFO.


Mitch

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/