linux-kernel - Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4780344.RfsAca3Qz3@vostro.rjw.lan>
Date:	Wed, 30 Apr 2014 00:39:11 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Stratos Karafotis <stratosk@...aphore.gr>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

On Wednesday, April 23, 2014 04:53:36 PM Stratos Karafotis wrote:
> On 23/04/2014 01:37 μμ, Rafael J. Wysocki wrote:
> > On Wednesday, April 23, 2014 12:13:54 AM Stratos Karafotis wrote:
> >> Fix the following checkpatch warnings:
> > 
> > In addition to comments from Viresh, I have a general one.
> > 
> > Some of the checkpatch.pl warnings are not worth fixing at all ->
> > 
> >> - WARNING: Prefer pr_err(... to printk(KERN_ERR ...
> >> - WARNING: Prefer pr_info(... to printk(KERN_INFO ...
> >> - WARNING: Prefer pr_warn(... to printk(KERN_WARNING ...
> >> - WARNING: quoted string split across lines
> >> - WARNING: line over 80 characters
> > 
> > -> and the "line over 80 characters" ones are outright wrong in many cases,
> > so please don't "fix" them.
> > 
> 
> Hi Rafael,
> 
> Thanks for your comments!
> 
> Could you please clarify if you want me to drop the entire patch or
> send it only with the changes about the last warning found ("no spaces
> at the start of a line)?
> 
> Also, I would like to take the opportunity and ask a question. :)
> 
> Reading the code, sometimes, I find some minor formatting issues.
> Like the checkpatch warnings or unnecessary parentheses and braces.
> 
> For example the line bellow:
> 		if ((freq < policy->min) || (freq > policy->max))
> 
> I know that this is not actually an issue and a patch with such changes
> is (somehow) a noise for the maintainers. But, should it be "fixed" or not?

It should be cleaned up generally, so if you have the time and you're willing
to do such things, please do them.

That said things like lines in excess of 80 characters may stay as they are.

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/