linux-kernel - Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140430064143.GM32718@rric.localhost>
Date:	Wed, 30 Apr 2014 08:41:43 +0200
From:	Robert Richter <rric@...nel.org>
To:	Myron Stowe <myron.stowe@...hat.com>
Cc:	bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	suravee.suthikulpanit@....com, aravind.gopalakrishnan@....com,
	kim.naru@....com, daniel@...ascale.com, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org, bp@...e.de,
	sp@...ascale.com, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range
 capabilities

On 18.04.14 20:53:23, Myron Stowe wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@....com>

> -		start = reg & 0xffffff00; /* 39:16 on 31:8*/
> -		start <<= 8;
> -		reg = read_pci_config(bus, slot, 1, 0x84 + (i << 3));
> +		start = (reg & 0xffffff00UL) << 8;	/* 39:16 on 31:8 */

I think this is not save anymore with respect to u32/u64 casting. The
original was.

-Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/