lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Apr 2014 10:19:35 +0100 From: Lee Jones <lee.jones@...aro.org> To: "Gupta, Pekon" <pekon@...com> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel@...inux.com" <kernel@...inux.com>, "computersforpeace@...il.com" <computersforpeace@...il.com>, "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, "dwmw2@...radead.org" <dwmw2@...radead.org>, "angus.clark@...com" <angus.clark@...com>, "Ezequiel Garcia (ezequiel.garcia@...e-electrons.com)" <ezequiel.garcia@...e-electrons.com> Subject: Re: [RFC 43/47] mtd: nand: stm_nand_bch: read and write functions (BCH) > >From: Lee Jones [mailto:lee.jones@...aro.org] > > > >Helper function for bch_mtd_read() and bch_mtd_write() to handle > >multi-page or non-aligned reads and writes respectively. > > > >Signed-off-by: Lee Jones <lee.jones@...aro.org> > >--- > > I think below code is duplicate of nand_do_read_ops() and nand_do_write_ops() > in nand_base.c. If you could just populate chip->ecc.read_page and > chip->ecc.write_page much of this could be avoided. chip->ecc.read_page and chip->ecc.write_page now populated. > Also, you need to break your bch_read_page() into given generic NAND > driver interfaces chip->ecc.calculate(), chip->ecc.correct() ... Our h/w calculates and corrects automatically. No need for intervention. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists