linux-kernel - Re: [PATCH] staging: rts5208: fix static checker warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53604FBE.2050701@realsil.com.cn>
Date:	Wed, 30 Apr 2014 09:19:58 +0800
From:	micky <micky_ching@...lsil.com.cn>
To:	<devel@...uxdriverproject.org>, <linux-kernel@...r.kernel.org>,
	<gregkh@...uxfoundation.org>
CC:	<rogerable@...ltek.com>, <wei_wang@...lsil.com.cn>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] staging: rts5208: fix static checker warnings

Hi Dan,

I have send this patch to fix the static checker warning, but not 
applied yet.

Best Regards.
micky.
On 04/02/2014 05:58 PM, micky_ching@...lsil.com.cn wrote:
> From: Micky Ching <micky_ching@...lsil.com.cn>
>
> The patch fa590c222fba: "staging: rts5208: add support for rts5208
> and rts5288" from Nov 12, 2013, leads to the following static checker
> warning:
> 	drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
> 	warn: add curly braces?
> This warning is produced because incorrect code indent.
>
> Signed-off-by: Micky Ching <micky_ching@...lsil.com.cn>
> ---
>   drivers/staging/rts5208/rtsx_chip.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index 6426807..7907e93 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -104,7 +104,7 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
>   	if (chip->ic_version >= IC_VER_C)
>   		reg |= DELINK_INT_EN;
>   #ifdef SUPPORT_OCP
> -		reg |= OC_INT_EN;
> +	reg |= OC_INT_EN;
>   #endif
>   	if (!chip->adma_mode)
>   		reg |= DATA_DONE_INT_EN;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/