linux-kernel - Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140430180314.GA3245@sirena.org.uk>
Date:	Wed, 30 Apr 2014 11:03:14 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	alsa-devel@...a-project.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org, lgirdwood@...il.com,
	robh+dt@...nel.org, sbkim73@...sung.com, rdunlap@...radead.org,
	dianders@...omium.org
Subject: Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

On Wed, Apr 30, 2014 at 05:30:39PM +0530, Tushar Behera wrote:

> XCLKOUT mux register (0x10040a00) is not part of core clock SFR range,
> rather it is part of pmu-system-controller node.

> One option would be to add a clock provider for XCLKOUT. That would
> require me to extend current clock driver to get the
> pmu-system-controller phandle which in turn is dependent on the patch to
> early initialize syscon driver.[1]

> Will it be okay to configure XCLKOUT in snow sound-card driver by taking
> the phandle of pmu-system-controller from device tree? The
> implementation is provided below.

I can't think of any reason why we'd not want to have this visible as a
clock?  Ideally we don't want to have any ASoC specific clock APIs when
we're done, the reason we do at the minute is that the clock API isn't
available as standard.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)