linux-kernel - Re: [PATCH 11/47] staging/lustre/ptlrpc: add rpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <12AE96A4-126C-4CC0-A875-E9D6E61C551B@linuxhacker.ru>
Date:	Tue, 29 Apr 2014 23:22:58 -0400
From:	Oleg Drokin <green@...uxhacker.ru>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Andriy Skulysh <Andriy_Skulysh@...atex.com>,
	Niu Yawei <yawei.niu@...el.com>
Subject: Re: [PATCH 11/47] staging/lustre/ptlrpc: add rpc_cache

Hello!

On Apr 29, 2014, at 5:46 AM, Dan Carpenter wrote:
>> 
>> +		/* Fall through */
>> 	case 7:
>> 		sptlrpc_fini();
>> -	case 5:
>> +		/* Fall through */
>> +	case 6:
>> 		ldlm_exit();
>> -	case 4:
>> +		/* Fall through */
>> +	case 5:
>> 		ptlrpc_stop_pinger();
>> -	case 3:
>> +		/* Fall through */
>> +	case 4:
>> 		ptlrpc_connection_fini();
>> -	case 2:
>> +		/* Fall through */
>> +	case 3:
>> 		ptlrpc_exit_portals();
>> +		/* Fall through */
>> +	case 2:
>> +		ptlrpc_request_cache_fini();
>> +		/* Fall through */
>> 	case 1:
>> 		ptlrpc_hr_fini();
>> 		req_layout_fini();
>> +		/* Fall through */
>> 	default: ;
>> 	}
>> 
> 
> Heh.  Oh wow.  That's horrible.  :P
> 
> Hopefully next time someone will fix this pile of monkey poo instead
> just renumbering all the grains of corn.

Agreed.
We actually have it fixed, but it again came with some other rework that
we are probably not ready to merge anywhere yet.
I guess I can extract just this cleanup ahead of time.

Bye,
    Oleg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/