linux-kernel - Re: [PATCH] staging: comedi: fix coding style issues in comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53620E50.8000406@mev.co.uk>
Date:	Thu, 1 May 2014 10:05:20 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Raghavendra Ganiga <ravi23ganiga@...il.com>,
	<hsweeten@...ionengravers.com>, <gregkh@...uxfoundation.org>
CC:	<devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

On 2014/05/01 09:23 AM, Raghavendra Ganiga wrote:
> This is a patch to fix coding style
> warnings found by checkpatch.pl tool
> 
> Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@...il.com>
> ---
>  drivers/staging/comedi/comedi_fops.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 70545e6..b24bf9b 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -668,6 +668,7 @@ static int do_devconfig_ioctl(struct comedi_device *dev,
>  			return -EBUSY;
>  		if (dev->attached) {
>  			struct module *driver_module = dev->driver->module;
> +
>  			comedi_device_detach(dev);
>  			module_put(driver_module);
>  		}
> @@ -2653,6 +2654,7 @@ static int __init comedi_init(void)
>  	/* create devices files for legacy/manual use */
>  	for (i = 0; i < comedi_num_legacy_minors; i++) {
>  		struct comedi_device *dev;
> +
>  		dev = comedi_alloc_board_minor(NULL);
>  		if (IS_ERR(dev)) {
>  			comedi_cleanup_board_minors();
> 

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>             )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587              )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/