linux-kernel - Re: [PATCH 1/1] mm/memcontrol.c: remove NULL assignment on static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140501125819.GB23420@cmpxchg.org>
Date:	Thu, 1 May 2014 08:58:19 -0400
From:	Johannes Weiner <hannes@...xchg.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] mm/memcontrol.c: remove NULL assignment on static

On Sat, Apr 26, 2014 at 10:50:31AM +0200, Fabian Frederick wrote:
> static values are automatically initialized to NULL
> 
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  mm/memcontrol.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 29501f0..6e38542 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -80,7 +80,7 @@ int do_swap_account __read_mostly;
>  #ifdef CONFIG_MEMCG_SWAP_ENABLED
>  static int really_do_swap_account __initdata = 1;
>  #else
> -static int really_do_swap_account __initdata = 0;
> +static int really_do_swap_account __initdata;
>  #endif
>  
>  #else

I actually like how this makes the 1 vs. 0 more obvious in this case,
even though it's not technically necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/