linux-kernel - Re: [PATCH 1/2] regulator: s5m8767: Allow GPIO 0 to be used as external control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140501175307.GD3245@sirena.org.uk>
Date:	Thu, 1 May 2014 10:53:07 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sangbeom Kim <sbkim73@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 1/2] regulator: s5m8767: Allow GPIO 0 to be used as
 external control

On Wed, Apr 30, 2014 at 10:40:41AM +0200, Krzysztof Kozlowski wrote:
> GPIO 0 is a valid GPIO so allow using it as external control for
> regulator.

Applied, thanks.  This is only safe because we don't have any actual
users of platform data - if we do have users of platform data then
things get a bit more tricky since the expectation with platform data is
that zero is the default/do nothing case.

Really if this is an issue it is better to fix things so that GPIO 0
doesn't get used for anything, with DT there's no need to do that since 
the numbers are all dynamic but it does get a little more tricky in the
platform data case sadly.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)