linux-kernel - Re: [PATCH 11/15] ASoC: WM0010 needs SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140501190842.GZ3245@sirena.org.uk>
Date:	Thu, 1 May 2014 12:08:42 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Xia Kaixu <kaixu.xia@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	arnd@...db.de, Liam Girdwood <lgirdwood@...il.com>,
	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Sangbeom Kim <sbkim73@...sung.com>,
	alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 11/15] ASoC: WM0010 needs SPI

On Tue, Apr 29, 2014 at 07:18:32PM +0800, Xia Kaixu wrote:

> @@ -201,7 +201,7 @@ config SND_SOC_SPEYSIDE
>  	select SND_SAMSUNG_I2S
>  	select SND_SOC_WM8996
>  	select SND_SOC_WM9081
> -	select SND_SOC_WM0010
> +	select SND_SOC_WM0010 if SPI
>  	select SND_SOC_WM1250_EV1

No, this is broken.  The driver won't work if all the components it uses
don't load and the dependency for SPI isn't SPI, it's SPI_MASTER.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)