linux-kernel - Re: [PATCH] regmap: Add missing initialization of this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140501034941.GU3245@sirena.org.uk>
Date:	Wed, 30 Apr 2014 20:49:41 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Opensource [Anthony Olech]" <anthony.olech.opensource@...semi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: Add missing initialization of this_page

On Tue, Apr 22, 2014 at 12:47:29PM +0200, Geert Uytterhoeven wrote:
> drivers/base/regmap/regmap.c: In function ‘_regmap_range_multi_paged_reg_write’:
> drivers/base/regmap/regmap.c:1665: warning: ‘this_page’ may be used uninitialized in this function
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> This may be a false positive, if "range" is guaranteed to be non-zero
> during the first iteration of the loop

Applied, though with this sort of thing it's generally a bit better to
do the init at the start of the loop rather than at declaration - init
at declaration is a common pattern for just shutting up warnings as
opposed to analyisng to make sure that there's really not an issue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)