linux-kernel - Re: [PATCH] staging/comedi: fix sparse warning: shift too big

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5363CCAE.9000006@mev.co.uk>
Date:	Fri, 2 May 2014 17:49:50 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Brilliantov Kirill Vladimirovich <brilliantov@...ox.ru>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging/comedi: fix sparse warning: shift too big

On 2014-05-02 15:57, Brilliantov Kirill Vladimirovich wrote:
> Signed-off-by: Brilliantov Kirill Vladimirovich <brilliantov@...ox.ru>
> ---
>   drivers/staging/comedi/drivers/ni_stc.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_stc.h b/drivers/staging/comedi/drivers/ni_stc.h
> index f0630b78..197b568 100644
> --- a/drivers/staging/comedi/drivers/ni_stc.h
> +++ b/drivers/staging/comedi/drivers/ni_stc.h
> @@ -717,7 +717,7 @@ enum AI_AO_Select_Bits {
>   static inline unsigned ni_stc_dma_channel_select_bitfield(unsigned channel)
>   {
>   	if (channel < 4)
> -		return 1 << channel;
> +		return 1 << (channel & 0x3);
>   	if (channel == 4)
>   		return 0x3;
>   	if (channel == 5)
>

The warning seems a bit spurious!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/